Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixes Lumen loadViewsFrom issue retrieving view config before the component is loaded #30404

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@kieranbrown
Copy link
Contributor

kieranbrown commented Oct 23, 2019

PHP 7.4 introduces a new error on a fresh install of Lumen when using the loadViewsFrom method:

Screenshot 2019-10-23 at 20 09 06

Steps to recreate:

  • Fresh Lumen installation
  • $app->register(Illuminate\Pagination\PaginationServiceProvider::class);

Proposed solution

Assign the view factory to a variable before iterating the config so that Lumen can register the view component first.

@kieranbrown kieranbrown changed the title [6.x] Fixes Lumen loadViewsFrom issue with retrieving view component config before it is loaded [6.x] Fixes Lumen loadViewsFrom issue with retrieving view config before the component is loaded Oct 23, 2019
@kieranbrown kieranbrown changed the title [6.x] Fixes Lumen loadViewsFrom issue with retrieving view config before the component is loaded [6.x] Fixes Lumen loadViewsFrom issue retrieving view config before the component is loaded Oct 23, 2019
@taylorotwell taylorotwell merged commit e3880cf into laravel:6.x Oct 24, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.