[6.x] Model dirty check bug fix #30565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for attributes that are cast to any type of Object, the strict equivalency (`===`) will never return `true`, because even though the values may be equal, the Object there reference will be different. this changes checks if the cast type is either `object` or `collection`, both with return Objects, and uses loose equivalency to compare them. even though date casting also returns an Object, we don't need to handle that since it's handled in the previous conditional. the test represents a scenario that occurs when using JSON fields in MySQL. MySQL returns the value with spaces between the elements, but `json_encode` returns a string **without** spaces between the elements.
|
to clarify, they will return true if the underlying string values are identical. but if that fails, and it falls through to try and compare the casted values, it will always be |
driesvints
reviewed
Nov 12, 2019
| { | ||
| $model = new EloquentModelCastingStub; | ||
| $model->setRawAttributes([ | ||
| 'objectAttribute' => '["one", "two", "three"]', |
There was a problem hiding this comment.
Suggested change
| 'objectAttribute' => '["one", "two", "three"]', | |
| 'objectAttribute' => '["one", "two", "three"]', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for attributes that are cast to any type of Object, the strict equivalency (
===) will never returntrue, because even though the values may be equal, the Objects they reference will be different.this changes checks if the cast type is either
objectorcollection, both which return Objects, and uses loose equivalency to compare them.even though date casting also returns an Object, we don't need to handle that since it's handled in the previous conditional.
the test represents a scenario that occurs when using JSON fields in MySQL. MySQL returns the value with spaces between the elements, but
json_encodereturns a string without spaces between the elements.References:
#30564
#28029