[6.x] Allow response to return first view #30651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently a couple ways to return a view. The simple standard way is:
If you need to customize the response a little you can tweak it to this:
Some code takes advantage of the ability to pass an array of views, and return the first one that exists.
It would be nice to be able to manipulate the response status and headers, but also use the view first functionality.
I'm proposing allowing
response()->view()
to accept either a string or array as the first parameter. If the first parameter is a string, it will behave as it does currently. If it receives an array, it will use the view first logic.If we're uncomfortable adding some magic to this method, I also considered making it a separate method on the ResponseFactory so it would be called as:
which I could switch to.
I was also having trouble locating where tests are for this logic. If someone could point me in the right direction that would be appreciated.