[6.x] Add wherePivotNotIn and orWherePivotNotIn methods #30671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to add more convenience.
Similar to what is done in
Illuminate\Database\Query\Builder
withwhereNotIn
andorWhereNotIn
, I added 2 methods calledwherePivotNotIn
andorWherePivotNotIn
.I did it in exactly the same way
whereNotIn
andorWhereNotIn
are built.Instead of a call like:
with this PR, developers could use
Basically,
$post->wherePivotIn('flag',['foo','bar'],'and',true);
will be called behind the scenes.I also added tests for both methods. Besides, since I could not find any test for the
orWherePivotIn
method which was already part of the framework before this PR, I added a test for this method also.Based on the contribution guide, I assumed it was a minor feature fully backward compatible since the added methods are new Laravel API methods which are not referenced anywhere else in the framework. That's why I pushed it to the latest stable branch. If you prefer to have it on the master branch, please let me know.
Also, if the PR is accepted, please let me know if you want to mention
wherePivotNotIn
in the documentation. I couldn't findorWherePivotIn
in the documentation, so I guess there is no need to addorWherePivotNotIn
either.