Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed some functions visibility to be public as other ones in the same class #30757

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@francauxach
Copy link
Contributor

francauxach commented Dec 4, 2019

Hi,
I've noticed that there are some protected functions for MySql and Postgres schema builder that were inaccessible from the Schema's Facade.

image

image

For that reason I think it's convenient to update the visibility of those functions so that they are public and can be used with the Facade.

I hope it helps!
Thanks,
Franc Auxach

@GrahamCampbell GrahamCampbell changed the title Fixed some functions visibility to be public as other ones in the same class [6.x] Fixed some functions visibility to be public as other ones in the same class Dec 4, 2019
@taylorotwell taylorotwell merged commit 5cbf934 into laravel:6.x Dec 4, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.