[6.x] Fix Builder::withCount() binding error when a scope is added into related model with binding in a sub-select #30869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current Laravel, Builder::withCount() causes an error if the related model has a scope which adds a sub-select with bindings, for example, the following scope attempts to add a column called "liked" into Likeable models, but causes an error when a model with it is loaded in Builder::withCount().
It's because Builder::withCount() removes extra columns added by the scope when loading the count, but forgets to remove the extra "select" bindings added.
This one-line patch fixes the problem.