Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Allow configurable emergency logger #30873

Merged
merged 4 commits into from Dec 18, 2019
Merged

Conversation

@Stokoe0990
Copy link
Contributor

Stokoe0990 commented Dec 18, 2019

This allows for an emergency logger channel config item in config/logging.php

Use case: Serverless environment or Docker container without persistent storage. If main logger fails, logs may be lost. This will help prevent that by allowing us to specify stderr or stdout as the logger's path. (This will allow us to forward logs onto an ELK stack etc.)

Relies on: laravel/laravel#5179

This allows for an emergency logger channel config item in config/logging.php

Use case: Serverless environment or Docker container without persistent storage. If main logger fails, logs may be lost. This will help prevent that by allowing us to specify stderr or stdout as the logger's path. (This will allow us to forward logs onto an ELK stack etc.)
@Stokoe0990

This comment has been minimized.

Copy link
Contributor Author

Stokoe0990 commented Dec 18, 2019

https://travis-ci.org/laravel/framework/jobs/626652915?utm_medium=notification&utm_source=github_status

memcached issue from TravisCI. Not sure what the cause of this is.

src/Illuminate/Log/LogManager.php Outdated Show resolved Hide resolved
@Stokoe0990 Stokoe0990 changed the title Allow configurable emergency logger [6.x] Allow configurable emergency logger Dec 18, 2019
@Stokoe0990

This comment has been minimized.

Copy link
Contributor Author

Stokoe0990 commented Dec 18, 2019

My bad! I just realised I used the storage_path() helper rather than $this->app->storagePath()

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Dec 18, 2019

I've already fixed this up. :)

@taylorotwell taylorotwell merged commit dba030b into laravel:6.x Dec 18, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.