Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed code that depended on getenv #30924

Merged
merged 3 commits into from Dec 25, 2019
Merged

[6.x] Fixed code that depended on getenv #30924

merged 3 commits into from Dec 25, 2019

Conversation

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Dec 24, 2019

If the env variables are loaded without using putenv, then getenv won't be able to see them, so the current code is wrong. It should use Laravel's env helper.

@GrahamCampbell GrahamCampbell added the bug label Dec 24, 2019
@antonkomarev

This comment has been minimized.

Copy link
Contributor

antonkomarev commented Dec 24, 2019

Maybe use Env support class instead of env helper method?

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

GrahamCampbell commented Dec 24, 2019

Maybe use Env support class instead of env helper method?

I'll do that in src, but not in tests, since all of the other tests use the global helper, and none of them use the Env class directly.

@taylorotwell taylorotwell merged commit a7db749 into 6.x Dec 25, 2019
4 checks passed
4 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@GrahamCampbell GrahamCampbell deleted the redis-env-fixes branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.