Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Bring in array subset code directly #30989

Merged
merged 3 commits into from Dec 31, 2019
Merged

[6.x] Bring in array subset code directly #30989

merged 3 commits into from Dec 31, 2019

Conversation

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Dec 31, 2019

Don't need my package anymore. Solves the problem of users not installing it.


The framework tests pass, but I've not tested this in a real app. We should probably do that with PHPUnit 8.4, 8.5, and 9.0-dev, and check they all work properly.

I can do that tomorrow if nobody else does it first. :)

@taylorotwell taylorotwell merged commit e949315 into 6.x Dec 31, 2019
4 checks passed
4 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@GrahamCampbell GrahamCampbell deleted the testbench branch Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.