Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix redis lock acquire #31168

Merged
merged 6 commits into from Jan 21, 2020
Merged

[6.x] Fix redis lock acquire #31168

merged 6 commits into from Jan 21, 2020

Conversation

@heroyan
Copy link
Contributor

heroyan commented Jan 19, 2020

Use set Ex NX to make the operation atomic, to avoid deadlock.

@GrahamCampbell GrahamCampbell changed the title redislock fix, use set Ex NX to make the operation atomic, to avoid d… [6.x] Fix redis lock acquire Jan 19, 2020
GrahamCampbell and others added 5 commits Jan 19, 2020
@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Jan 20, 2020

@heroyan please provide a thorough explanation what this fixes. I also guess this is for #31166 ?

Can you maybe also provide a test for this?

@taylorotwell

This comment has been minimized.

Copy link
Member

taylorotwell commented Jan 20, 2020

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@taylorotwell taylorotwell reopened this Jan 21, 2020
@taylorotwell taylorotwell merged commit 5a7a8f4 into laravel:6.x Jan 21, 2020
1 check passed
1 check passed
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.