Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Macroable parent __call #31286

Closed
wants to merge 2 commits into from
Closed

[6.x] Macroable parent __call #31286

wants to merge 2 commits into from

Conversation

4n70w4
Copy link
Contributor

@4n70w4 4n70w4 commented Jan 29, 2020 •
edited
Loading

Currently, when using Macroable trait in eloquent models, an exception occurs:

    "message": "Method App\\Organization::hydrate does not exist.",
    "exception": "BadMethodCallException",
    "file": "/var/www/app/vendor/laravel/framework/src/Illuminate/Support/Traits/Macroable.php",
    "line": 103,

This PR fix it. Also it up code coverage for SupportMacroableTest to 100%.

@4n70w4 4n70w4 mentioned this pull request Jan 29, 2020
Closed
@4n70w4 4n70w4 changed the title Macroable parent __call [6.x] Macroable parent __call Jan 29, 2020
@taylorotwell
Copy link
Member

Breaking change and not sure this is thought through.

This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4n70w4 @taylorotwell