Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Make Blueprint support Grammar's macro #31365

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@hafezdivandari
Copy link
Contributor

hafezdivandari commented Feb 5, 2020

According to #31296, this PR makes Blueprint support Grammar's macro when building raw SQL statements from Fluent commands using toSql() method.

Note: I've used hasMacro() on this PR to check if the macro is registered on the Grammar class. I guessed the #31337 PR was reverted because it was wrongly using is_callable() which always returns true if the target class has __call() magic method.

@taylorotwell taylorotwell merged commit 38f9fa4 into laravel:6.x Feb 5, 2020
1 check passed
1 check passed
continuous-integration/styleci/pr The analysis has passed
Details
@hafezdivandari hafezdivandari deleted the hafezdivandari:macroable_blueprint branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.