Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Added query builder support for groupByRaw #31498

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

rentalhost
Copy link
Contributor

@rentalhost rentalhost commented Feb 17, 2020

  • Tests added: 2;
    • Test SQL generated for groupByRaw() with bindings;
    • Test SQL generated for groupbyRaw() with mixed binding types to ensure that bindings order is respected;
  • Tested in a real project;
  • Based at v6.15.1;

Fixes laravel/ideas#1112.

@taylorotwell taylorotwell merged commit a1dc376 into laravel:6.x Feb 18, 2020
@kevinb1989
Copy link
Contributor

Perfect! I have always wanted this feature.

@GrahamCampbell GrahamCampbell changed the title [6.x] Illuminate\Database\Query\Builder: added support to groupByRaw($sql, array $bindings = []) [fixes #1112]. [6.x] Added query builder support for groupByRaw Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Add groupByRaw
5 participants