Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Improved the reflector #33184

Merged
merged 2 commits into from
Jun 11, 2020
Merged

[6.x] Improved the reflector #33184

merged 2 commits into from
Jun 11, 2020

Conversation

GrahamCampbell
Copy link
Member

  1. Fixed treatment of union types in PHP 8. Foo|null and ?Foo will be treated as "Foo", Foo|Bar will be treated as null.
  2. Fixed treatment of self typing. self declared in a parameter in a method defined in class Foo will be treated as "Foo", even if the reflection parameter was generated from querying a class Bar that extends or implements Foo. This mimics the behaviour of getClass on PHP 7, which was removed in PHP 8 (which is what we are here to simulate).

Closes #33177.

@taylorotwell taylorotwell merged commit 86c43ad into 6.x Jun 11, 2020
@driesvints driesvints deleted the reflector branch June 11, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants