[8.x] Dispatch 'connection failed' event in http client #37740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdebrauwer
changed the title
|
Hi @gdebrauwer In laravel 10.* there is an error dispatching this, Illuminate\Http\Client\Events\ConnectionFailed::__construct(): Argument #1 ($request) must be of type Illuminate\Http\Client\Request, null given, called in /app/vendor/laravel/framework/src/Illuminate/Http/Client/PendingRequest.php on line 1386 |
|
@SergkeiM Can you create a bug issue with some code on how to reproduce it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a
ConnectExceptionis thrown by Guzzle, then no event is fired as there is no response. This PR adds aConnectionFailedevent that is fired before Laravel throws its ownConnectionException.This event will make it possible to also track those failed requests in Telescope or other tools that listen for the events of the Http Client.
I did not add a test for this because I could not find an existing test that simulates a Guzzle
ConnectException.