Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Ensure alias is rebound when mocking items in the container #37810

Merged
merged 2 commits into from
Jun 25, 2021
Merged

[8.x] Ensure alias is rebound when mocking items in the container #37810

merged 2 commits into from
Jun 25, 2021

Conversation

Nacoma
Copy link
Contributor

@Nacoma Nacoma commented Jun 24, 2021 •
edited by GrahamCampbell
Loading

Closes #37789.

@GrahamCampbell GrahamCampbell changed the title ensure alias is rebound when mocking items in the container (issue #3… [8.x] Ensure alias is rebound when mocking items in the container Jun 24, 2021
@taylorotwell taylorotwell merged commit ef420d1 into laravel:8.x Jun 25, 2021
@taylorotwell taylorotwell mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test using $this->mock(Request::class) always returning empty GET request
2 participants
@Nacoma @taylorotwell