[8.x] Add AssertableJson::each() method #38684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* add AssertableJson::each() method * add tests for new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
each()method, similar tofirst()on the\Illuminate\Testing\Fluent\AssertableJsonclass to assert on each element of the current JSON.This is helpful if you want to ensure that every object in the
datakey has the same structure for example. Or that each element has a0 <= price <= 10to test filter logic.I'm not sure if that method should be added as abstract to
\Illuminate\Testing\Fluent\Concerns\Haslike thefirst()right now. If so I would assume that this is a breaking change and should be targeted to Laravel 9!?