[9.x] Fix implicitBinding and withTrashed route with child with no SoftDeletes trait #41282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue caused when using implicitBinding and withTrashed on a route and where the parent model has the SoftDelete trait and the child doesn't have the SoftDelete trait.
Ex:
The following route call
/users/1/posts/2
will throw this errorCall to undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::withTrashed()
.This PR adds an extra check to verify if the child model instance has the SoftDeletes trait.