[9.x] Enable dispatchAfterResponse for batch 🔥#41787
Merged
taylorotwell merged 2 commits intoApr 4, 2022
Merged
Conversation
[before] batch can't be dispatched after response sent to user. [after] batch can be dipatched and all jobs will be saved to storage after response. - added dispatchAfterResponse method to: 1- store batch itself into database 2- register a terminating callback to dispatch batch jobs 3- return created batch - added private dispatchAlreadyCreated method to: 1- dispatch batch jobs and fire BatchDispatched event like before but without creating batch because we already created it in dispatchAfterResponse
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Apr 5, 2022
* [9.x] Enable dispatchAfterResponse for batch 🔥 [before] batch can't be dispatched after response sent to user. [after] batch can be dipatched and all jobs will be saved to storage after response. - added dispatchAfterResponse method to: 1- store batch itself into database 2- register a terminating callback to dispatch batch jobs 3- return created batch - added private dispatchAlreadyCreated method to: 1- dispatch batch jobs and fire BatchDispatched event like before but without creating batch because we already created it in dispatchAfterResponse * formatting Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Batch can't be dispatched after the response is sent to the user.
After
Batch can be dispatched and all jobs will be saved to storage after response.
Use Case
Changes
batch because we already created it in dispatchAfterResponse
Example