[9.x] Allow to use custom log level in exception handler reporting #41925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Renamed Nice feature - thanks! |
|
Thanks @taylorotwell ! 🥳 |
GrahamCampbell
changed the title
taylorotwell
pushed a commit
that referenced
this pull request
Apr 12, 2022
fix #41925 review comments
ankurk91
added a commit
to ankurk91/laravel-stripe-exceptions
that referenced
this pull request
May 11, 2022
Comment on lines
+266
to
+271
| $level = Arr::first($this->levels, function ($level, $type) use ($e) { | ||
| return $e instanceof $type; | ||
| }, LogLevel::ERROR); | ||
|
|
||
| $logger->log( | ||
| $level, |
There was a problem hiding this comment.
@taylorotwell this is a breaking change for tests. 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new property
$reportLogLevelsand corresponding methoduseLogLevel()to the exception handler. These allow the user to configure different log levels for any exception. This will make it easier to reportPDOExceptions as critical and known/common user exceptions as debug or whatever you want.solves #41921