[9.x] Use config session domain for maintenance cookie#41961
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Apr 13, 2022
Jefemy:9.x
Merged
[9.x] Use config session domain for maintenance cookie#41961taylorotwell merged 1 commit intolaravel:9.xfrom Jefemy:9.x
taylorotwell merged 1 commit intolaravel:9.xfrom
Jefemy:9.x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the code proposed in #35036.
The current maintenance cookie only applies to the domain the secret request was sent to. This causes problems for multi subdomain setups as you would need to send that request to each subdomain to get the proper cookies even though they are all served by the same Laravel application. This PR simply hooks the cookie up to the already used config for session domains to fix the problem.