[9.x] Add the ability to use alias when performing upsert via MySQL #42053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Laravel's upsert default behaviour uses the
values()
function that is deprecated and MySQL >= 8.0.20 will throw a warning when using thevalues()
function inupsert
:Reference
Expected behaviour
MySQL >= 8.0.20 does not throw any warnings when using
Model::upsert()
.How?
Update the behaviour of MySqlGrammar@compileUpsert to use the alias (instead of
values
) in the upsert query when it is configured in the newdatabase.{mysql-database}.use_upsert_alias
config value.Why can't we update it to always use aliases?
The alias in
upsert
is only supported beginning with MySQL 8.0.19, so it won't work with earlier versions:Reference
As the other option, a fourth parameter (instead of adding a new config values)
(bool $useAlias = false)
can be added to the method to makeupsert
use the alias.