Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Tweak event:list command #42084

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Apr 21, 2022

  • It enforces forward-slash for closure file paths on windows.
  • It shows implemented interfaces for classy listeners (ShouldQueue) and (ShouldBroadcast).

This snapshot is taken on windows:
image

@imanghafoori1 imanghafoori1 force-pushed the tweak_event_list branch 4 times, most recently from 650fe8d to 9472404 Compare April 21, 2022 21:29
}

if (in_array(ShouldBroadcast::class, $interfaces)) {
$listener .= ' <fg=bright-blue>(ShouldBroadcast)</>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listeners aren't broadcast, events are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a mistake!

@taylorotwell taylorotwell merged commit e1ca235 into laravel:9.x Apr 22, 2022
@imanghafoori1 imanghafoori1 deleted the tweak_event_list branch April 22, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants