Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Update NotificationFake with notifications getter #43558

Merged
merged 1 commit into from Aug 5, 2022

Conversation

mikkoaf
Copy link
Contributor

@mikkoaf mikkoaf commented Aug 5, 2022

When testing notifications this is super handy for testing whether the correct notifications have been sent. A similar method is available in the QueueFake with Queue::pushedJobs(). Having Notification::sentNotifications() adds consistency between the Fake Facades.
Relates to: #27089

When testing notifications this is super handy for testing whether the correct notifications
have been sent. Similar method is available in the QueueFake with `Queue::getJobs()`
@taylorotwell taylorotwell merged commit 6cb7418 into laravel:9.x Aug 5, 2022
17 checks passed
@mikkoaf mikkoaf deleted the notification-fake-patch-1 branch Aug 8, 2022
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
When testing notifications this is super handy for testing whether the correct notifications
have been sent. Similar method is available in the QueueFake with `Queue::getJobs()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants