Skip to content

[9.x] Update NotificationFake with notifications getter - #43558

Merged
taylorotwell merged 1 commit into
laravel:9.xfrom
mikkoaf:notification-fake-patch-1
Aug 5, 2022
Merged

[9.x] Update NotificationFake with notifications getter#43558
taylorotwell merged 1 commit into
laravel:9.xfrom
mikkoaf:notification-fake-patch-1

Conversation

@mikkoaf

@mikkoaf mikkoaf commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

When testing notifications this is super handy for testing whether the correct notifications have been sent. A similar method is available in the QueueFake with Queue::pushedJobs(). Having Notification::sentNotifications() adds consistency between the Fake Facades.
Relates to: #27089

When testing notifications this is super handy for testing whether the correct notifications
have been sent. Similar method is available in the QueueFake with `Queue::getJobs()`
@taylorotwell
taylorotwell merged commit 6cb7418 into laravel:9.x Aug 5, 2022
@mikkoaf
mikkoaf deleted the notification-fake-patch-1 branch August 8, 2022 05:07
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
When testing notifications this is super handy for testing whether the correct notifications
have been sent. Similar method is available in the QueueFake with `Queue::getJobs()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants