[9.x] Add a new function onlyTrashed - #44989
Merged
Merged
Conversation
Contributor
|
The naming seems off on this for me. “Only trashed” reads to me as if it’ll only check soft-deleted records; not omit soft-deleted (trashed) records when doing the exists/unique checking 😕 |
Contributor
@martinbean Well, it reads to you just fine, because it really checks only within soft-deleted items 🤯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an "onlyTrashed" validation rule in
ExistsandUnique.For example, we want a user to be able to create a new row in the database user, but we want to search in the database where the
deleted_atis not null.And the same since the same function is in the same trait
SoftDeletesUsage: