[10.x] Add Support for SaveQuietly and Upsert with UUID/ULID Primary Keys #46161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFSThiagoBR98
changed the title
TFSThiagoBR98
changed the title
joelharkes
reviewed
Mar 28, 2023
|
The uuids are set later now in the events loop, i don't understand how this is not seen as a breaking change? |
|
@joelharkes Good point, I'll send a PR to move the setUniqueIds to before the creating event |
TFSThiagoBR98
added a commit
to TFSThiagoBR98/framework
that referenced
this pull request
Mar 29, 2023
This fixes a BC caused by PR laravel#46161
taylorotwell
pushed a commit
that referenced
this pull request
Mar 29, 2023
* Move SetUniqueIds to run before the creating event This fixes a BC caused by PR #46161 * Update Model.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the framework sets the unique ids before saving via the 'creating' event, however this does not work when trying to use saveQuietly which ignores all events or upsert which does not fire the 'creating' event, this PR changes it to not use events but be called directly in the performInsert and upsert methods, as it is done to set timestamp values.
Add some tests for this use case.
Related #44430