Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix(src\illuminate\Queue): update doc block, Simplification of the code in RedisManager #50635

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

saMahmoudzadeh
Copy link
Contributor

This PR removes the redundant @param doc block

Given the method signature:

    /**
     * Migrate the delayed jobs that are ready to the regular queue.
     *
     * @param  string  $from
     * @param  string  $to
     * @param  int  $limit
     * @return array
     */
    public function migrateExpiredJobs($from, $to)
    {

the @param int $limit expression is unnecessary and can be removed from the doc block.

parseConnectionConfiguration method in RedisManger.php class

//Before
return ! in_array($key, ['driver'], true);

//After
return $key !== 'driver';

It seems clearer to me.

Thanks!

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@saMahmoudzadeh saMahmoudzadeh marked this pull request as ready for review March 19, 2024 01:52
@taylorotwell taylorotwell merged commit 9caf1ab into laravel:11.x Mar 19, 2024
30 checks passed
@saMahmoudzadeh saMahmoudzadeh deleted the fix/fix-doc-block branch March 20, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants