[11.x] Add decrement method to the rate limiter class #51102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a scenario with a third party API where I was calling their API on a rate limited job. The job was consumed and therefore reduced the rate limit, but I wanted to catch the exception and decrease the rate limit again.
I could get around this by calling RateLimiter::increment(...) and passing it a negative value e.g. -1, but thought it would be a nicer DX to have a decrement method available like in other cache classes.
I have followed the approach for how other cache classes achieve this for consistency.