[11.x] fix: Factory::createMany creating n^2 records #51225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Closes #51224
This PR fixes the N^2 issue when using
EloquentFactory::createMany
with a count. I went with Option 1 given in the issue, so passing an argument tocreateMany
will overwrite any previous count set on the model---leaving the argnull
will use the count set on the model.If you'd like me to change the behaviour for that one edge case, just let me know!
Thanks!