Skip to content

[10.x] Fix SQL Server detection in database store - #51547

Merged
taylorotwell merged 1 commit into
laravel:10.xfrom
staudenmeir:sqlserver-cache
May 23, 2024
Merged

taylorotwell merged 1 commit into
laravel:10.xfrom
staudenmeir:sqlserver-cache

Conversation

@staudenmeir

Copy link
Copy Markdown
Contributor

Laravel doesn't have an insertOrIgnore() implementation for SQL Server and so the database store checks the connection class to see if the method can be used. However, the current detection logic doesn't work when the app uses a custom connection class that extends SqlServerConnection (e.g. when a package overrides it). By using instanceof, we also support theses cases.

@MightyPork

Copy link
Copy Markdown

This same issue occurs for the MongoDB database driver.

mongodb/laravel-mongodb#1815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants