Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] fix: improve performance and robustness of Relation::getMorphAlias() #51845

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Jun 19, 2024

Hello!

Please see #51809 (comment) for context.

Thanks!

@calebdw calebdw changed the title fix: improve performance and robustness of Relation::getMorphAlias() [11.x] fix: improve performance and robustness of Relation::getMorphAlias() Jun 19, 2024
@taylorotwell taylorotwell merged commit 02a0b5f into laravel:11.x Jun 19, 2024
28 checks passed
@calebdw calebdw deleted the morph_alias branch June 19, 2024 21:16
@shengslogar
Copy link
Contributor

Coming off of the parent comment thread, was there any discussion about calling this getMorphClass to match the name of HasRelationships->getMorphClass()? It would make more sense to me to call it getMorphAlias if we weren't falling back to the class name (like the original PR). In its current state, it seems like these methods should reference each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants