Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minio install to /opt/bin #1754

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

bastien-phi
Copy link
Contributor

Fixes #1753

Executable path in minio.service was changed minio/minio-service@471819a#diff-21b7b15c6eb3f6e340ef6f048041d90f2837b4179089004e6d3ec252a795a4c1

It should fix minio installation issue

@svpernova09 svpernova09 merged commit 0119780 into laravel:main Jan 25, 2022
@mbalandis
Copy link

@bastien-phi Thank you very much!

@bastien-phi bastien-phi deleted the fix_minio_install branch January 25, 2022 15:49
@bastien-phi
Copy link
Contributor Author

Glad to help !

@satyago
Copy link

satyago commented Jan 26, 2022

@mbalandis Did this solve your problem?
I am unfortunately not seeing any success with this.

The minio server fails to boot, likely due to the minio.service file containing wrong config?
I am ashamed to say that I don't work with installing system services often enough to know the quirks and get around them.
Does this ring a bell to you? @bastien-phi

journalctl -u minio
-- Logs begin at Wed 2022-01-26 11:46:29 UTC, end at Wed 2022-01-26 12:01:35 UTC. --
Jan 26 11:47:11 acme-app systemd[1]: /etc/systemd/system/minio.service:13: Unknown key name 'ProtectProc' in section 'Service', ignoring.
Jan 26 11:47:11 acme-app systemd[1]: minio.service: Starting requested but asserts failed.
Jan 26 11:47:11 acme-app systemd[1]: Assertion failed for MinIO.

I don't want this linked to another thread (unfortunately already happened as per my deleted comment), but let me quote what I found:

[...] ProtectProc isn't a thing on 20.04 [...]

[EDIT] the line above seems to be a warning, is ignored (shown but didn't read), thus irrelevant here.

I am unaware at this moment how to debug the failed assertion.
See update below.

@satyago
Copy link

satyago commented Jan 26, 2022

Update:
It is rather obvious once one gets to it, but the entire config at https://github.com/minio/minio-service/blob/master/linux-systemd/minio.service is out of date based on the above path change findings.
This results in the service not starting, obviously.

Not sure what the resolution is, as logically speaking that configuration is to blame and needs an update.
But there may be reasons that this change hasn't been applied there yet (it's not on master).

@mbalandis
Copy link

@satyago

I have yet had a chance to test it as I booted the large vm and am in middle of work without the minio loaded in. I will have a look as soon as I can but seeing that it doesn't boot to you it is likely it won't for me. I will give an update once I know more.

@bastien-phi
Copy link
Contributor Author

@satyago

Looks like this PR has to be reverted as the commit in minio/minio-service was deleted...

image

I had the change to launch my homestead between homestead release and commit revert.

I will PR the revert of this one

bastien-phi added a commit to bastien-phi/homestead that referenced this pull request Jan 26, 2022
svpernova09 pushed a commit that referenced this pull request Jan 26, 2022
@mbalandis
Copy link

mbalandis commented Jan 26, 2022

@satyago @bastien-phi I did a quick run on fresh Laravel project with latest homestead with minio enabled and it seemed to boot. It didn't show the installation progress bars but when I visit the :9600 it has console and i can log in.
Don't take my word for it, maybe something is still wrong but have a go. I didn't get an error you had.

Same Homestead.yaml like in Issue #1753

Note: I see the revert was done I maybe that fixed it? I literally tried 10min before posting this :) If that is the case then it was just a mess up on minio end that caused unnecessary problems.

@satyago
Copy link

satyago commented Jan 28, 2022

I can confirm it is working again.
And yes, the configuration script and the installation path have all been out of sync, so the service couldn't start.
With that being resolved, it was correctly installing and booting again.

I was really struggling to stay sane and see the issue in the first place !
Somehow I was expecting something far more complicated and looked in the wrong places.

Thank you for the help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minio is borked
4 participants