-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Update to bootstrap 5.1 and drop jQuery #1119
Conversation
Popper.js is needed for tooltips, using the browser native title attribute removes the need to keep this
can we just update to Tailwind instead? |
@browner12 would be doable. I think the only problems that came to my mind was modals which would need a custom implementation. Luckily the tailwindcss ecosystem provides headlessui which gives us modals out of the box. I would be open to this. depends on Taylor |
I've never made a big effort to change to Tailwind because that end user doesn't know or care how it is implemented and therefore there is no "return on investment" in changing it - just the risk of introducing regressions... no upside whatsoever since we already have a working UI IMO. |
I think there are 2 benefits I'd advocate for in switching to Tailwind which lend to an ROI.
Obviously I'm not the one who has to spend the time coding it, so just my opinion. For the business I understand how it's difficult to justify. |
@mmachatschek totally forgot about this PR and we're now getting a whole bunch of merge conflicts... I feel like this PR could have perfectly gone into 5.x as well. If you're up for it, feel free to send it that way! |
@driesvints I try to resend it to the 5.x branch. but that probably needs some additional checks as jess has made a lot of changes to the design. i need to go through the migration guide again |
This PR updates bootstrap from 4.6 to 5.1 and applies the migration steps from https://getbootstrap.com/docs/5.1/migration/
Additionally I managed to remove jQuery and replace its usage with vanilla JS.
This does mainly the same thing like laravel/telescope#1179 and additionally removes the popper.js dependency.