Add horizon:reset-metrics
command
#1318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a Job is renamed or moved, it will persist in Horizon under Metrics and never be removed. This ends up cluttering the Metrics with obsolete jobs. The problem is described in #1152
Solution
The simplest solution IMO is to just add a command to reset the metrics for Horizon entirely. I've given this command the signature
horizon:reset-metrics
.It will remove all metric data in Horizon's Redis database, including:
measured_jobs
/measured_queues
job:*
/queue:*
snapshot:*
last_snapshot_at
metrics:snapshot
I believe I have covered everything relating to metrics without touching anything else.
Additionally, because I have to search Redis by wildcard to find some of the metrics data, I used SCAN instead of KEYS which is what Redis recommends to prevent locking issues:
After Running Command