[5.x] Feature: Warn if no supervisor config (#1447) #1451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudikubota
changed the title
driesvints
approved these changes
May 27, 2024
There was a problem hiding this comment.
This is better but I also wonder if we should start Horizon at all if no supervisor config was found. Will let @taylorotwell wage in here.
|
No plans to take any action here. |
|
@yudikubota looks like we're going to leave things be for now, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1447, users may run
php artisan horizonin a different environment and forget to configure the supervisors for this new environment. This feature warns if there are no supervisors configured for the current environment.This PR implements:
Obs.
It's possible to warn from the MasterSupervisor output but I think the HorizonCommand is more appropriate.