Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install command output to display vite build command #1109

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Update install command output to display vite build command #1109

merged 1 commit into from
Aug 5, 2022

Conversation

RhysLees
Copy link
Contributor

@RhysLees RhysLees commented Aug 4, 2022

This PR changes Please execute the [npm install && npm run dev] commands to build your assets.
to Please execute the [npm install && npm run build] commands to build your assets. to reflect the move to vite.

@RhysLees RhysLees changed the title Update install command to display vite build Update install command output to display vite build command Aug 4, 2022
@jessarcher
Copy link
Member

I'm not suggesting you change this PR as I don't know Taylor's thoughts, but the laravel installer (also used by laravel.build) automatically runs npm install && npm run build on the Jetstream install. I wonder whether that should be moved to this repo so that it happens consistently no matter how you install it.

We could then mention both options so the user knows their options going forward:

Run [npm run build] to re-build your assets, or [npm run dev] to start the hot module replacement server.

@taylorotwell taylorotwell merged commit ff6e052 into laravel:2.x Aug 5, 2022
@taylorotwell
Copy link
Member

@jessarcher I would be open to some improvements as you mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants