Call storage:link on install
#1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetstream's profile photos feature requires the
public/storagesymlink to work correctly.Currently, this is created automatically in the
laravelinstaller when you run it with--jet, however, the Laravel installer is not documented and is typically run via thelaravel.buildservice, which does not support the--jetflag.This PR adds
storage:linkto the install command so that it is always run regardless of which method is used to install Jetstream.There is a PR at laravel/installer#245 to remove it from the installer.
I have tested this with the storage symlink already in place, and it silently carries on without issue.