Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include autocomplete on all relevant elements. #13

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Include autocomplete on all relevant elements. #13

merged 4 commits into from
Sep 2, 2020

Conversation

Bradez
Copy link
Contributor

@Bradez Bradez commented Sep 2, 2020

This pull request adds an autocomplete attribute on all relevant elements to better comply with the HTML standard and improve user experience through improved browser autocomplete detection.

Copy link
Contributor

@innocenzi innocenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep name instead of specifying nickname. Either way, good change 👍

taylorotwell and others added 3 commits September 2, 2020 08:20
…ion-form.blade.php

Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
@taylorotwell taylorotwell merged commit ce5cdf6 into laravel:master Sep 2, 2020
@Bradez
Copy link
Contributor Author

Bradez commented Sep 2, 2020

@innocenzi, the reason for not using name is because name denotes full name (ie. Sir Timothy John Berners-Lee) and it's an assumption that it would be used for a full name that includes honorific prefix / suffix and middle name.

nickname, on the other hand, is typically a shorter name (could be a nickname, a screen name, a handle, etc.). That seems more likely what's going to be used here.

Finally, there's username although that's use-case specific. In Laravel's default configuration, it's not unique and therefore not a username.

In the end, nickname seems more appropriate than name.

@innocenzi
Copy link
Contributor

@Bradez While I agree that it's more likely that a shorter name is going to be used, the MDN still recommends using name instead of breaking down the field with more specific attributes.

Using "name" rather than breaking the name down into its components is generally preferred because it avoids dealing with the wide diversity of human names and how they are structured

In the eventuality that the user wants to register a full name, the autocompletion will be more complete. So I still think name is more appropriate than nickname for the vast majority of cases, and the developers using Jetstream will be able to change that easily if they want more specificity. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants