[1.x] Fix purging of CSS classes on production builds #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix style issues add trailing commas keep vendor at the top
johanvanhelden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If you do not publish the Jetstream views, those CSS classes will be purged from Tailwind on production builds, resulting in broken layouts.
Example:
Solution:
This PR fixes this issue and allows the Jetstream views to remain unpublished by simply including Jetstream in the list of folder PostCSS needs to search for classes.
Result:
Why:
Keeping, non-customized, views unpublished is what I prefer because it keeps my repository clean and I only publish files I actually need to modify.
Really fixes: #170