[1.x] Added hasTeamRole check on the HasTeams trait. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added hasTeamRole check on the HasTeams trait.
Added assertion to test if the function works.
Removed the white spacing that was added by accident.
Removed the white spacing that was added by accident.
wotta
changed the title
|
Thanks for merging🙂 |
|
@wotta can you also send in a PR to the docs for this method? |
|
Sure thing. Mind if I do that tonight? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added this check because we do have a
hasTeamPermissionfunction but I missed a function to check if the team has a specific role.When I checked the trait I saw the following function
teamRolewhich returns the role object.So when I saw that I wanted to add a function that returns true or false based on the fact if the role actually exists.
I would love to read your opinion on this pull request.