Delete user tokens when user is deleted #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete a users token once user is deleted
|
I wonder if this would be better implemented as a cascading delete foreign key constraint? |
|
Yeah, I guess cascade would be the better option here to be fair. I should also run tests locally before pushing 🤦♂️ Should I change to cascade? |
|
That's how I would personally do it. |
|
That'd mean the change has to be done in the laravel/sanctum migration? As jetstream uses sanctum for this and the migration is there. |
|
Ick. It's morphable too. Your PR may be the best approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a user is deleted, their api tokens will remain inside the database. The api tokens are now deleted at the same time the user will be deleted.