Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Fix feature toggles in Inertia #451

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[1.x] Fix feature toggles in Inertia #451

merged 1 commit into from
Nov 12, 2020

Conversation

driesvints
Copy link
Member

Fixes #445

@taylorotwell taylorotwell merged commit 2377572 into 1.x Nov 12, 2020
@taylorotwell taylorotwell deleted the fix-feature-toggles branch November 12, 2020 14:36
@ManojKiranA
Copy link

Hi @driesvints ,

I think currently we are not sharing those config to Inertia

ShareInertiaData.php#L23

Which may cause

Cannot read property 'canManageUpdateProfileInformation' of undefined"

and also the keys which we don't share to frontend

@driesvints
Copy link
Member Author

That's odd because these worked for me. I did have to recompile my assets.

@driesvints
Copy link
Member Author

driesvints commented Nov 13, 2020 •
edited
Loading

I've sent in a fix for this: #454. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inertia Stack doesn't respect fortify config
3 participants
@driesvints @ManojKiranA @taylorotwell