Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clears any validation error message before re-displaying confirmation #487

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

telkins
Copy link
Contributor

@telkins telkins commented Nov 25, 2020

It's a small change, but it should be OK. 🤓

Previously, there was a very minor issue if the following steps were followed:

  • log in
  • navigate to profile
  • delete account
  • enter incorrect password
  • note the validation error message
  • close confirmation window via ESC or Nevermind
  • delete account...again

The issue: the validation error message is still displayed.

I've simply added $this->resetErrorBag(); to make sure that validation errors are cleared each time the user attempts to delete their account.

Please let me know if there are any problems/questions. Thx...! 🤓

It's a small change, but it should be OK.  🤓 

Previously, there was a **very minor** issue if the following steps were followed:
- log in
- navigate to profile
- delete account
- enter incorrect password
- note the validation error message
- close confirmation window via ESC or Nevermind
- delete account...again

The issue: the validation error message is still displayed.

I've simply added `$this->resetErrorBag();` to make sure that validation errors are cleared each time the user attempts to delete their account.

Please let me know if there are any problems/questions.  Thx...!  🤓
@taylorotwell taylorotwell merged commit 1cd1566 into laravel:1.x Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants