Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Use defineComponent in vue stubs for easier typescript setup #869

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

studnitz
Copy link
Contributor

As discussed in #867, this PR adds a defineComponent() around the export default { ... } component options of all Vue components.

defineComponent is just a function that returns the object passed into it. But it makes life easier for people, who want to use Typescript in their Jetstream project.

@studnitz studnitz changed the title Use defineComponent in vue stubs for easier typescript setup [2.x] Use defineComponent in vue stubs for easier typescript setup Aug 31, 2021
@taylorotwell taylorotwell merged commit 5d9932a into laravel:2.x Aug 31, 2021
@driesvints
Copy link
Member

Thanks @studnitz

@studnitz studnitz deleted the vue-define-component branch August 31, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants