Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fixed DocBlocks #1187

Merged
merged 8 commits into from
Sep 3, 2021
Merged

[8.x] Fixed DocBlocks #1187

merged 8 commits into from
Sep 3, 2021

Conversation

dunhamjared
Copy link
Contributor

  • Replaced @inheritDoc -- missing parent member with doc comments
  • Updated docblock for gatherMiddlewareClassNames -- the $middleware parameter can handle arrays and the callLumenControllerWithMiddleware function passes an array

@taylorotwell
Copy link
Member

Please always use fully qualified class names in doc blocks.

@driesvints driesvints marked this pull request as draft September 3, 2021 06:20
@driesvints
Copy link
Member

Mark this as ready when you've converted to FQN, thanks.

@dunhamjared
Copy link
Contributor Author

dunhamjared commented Sep 3, 2021

Ok, I sifted through the src directory and found a few more doc blocks that needed fully qualified class names.

Also discovered two more @inheritdoc that were missing parent members with doc comments.

@dunhamjared dunhamjared marked this pull request as ready for review September 3, 2021 15:08
@taylorotwell taylorotwell merged commit f5ae0d0 into laravel:8.x Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants