Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater styling #6166

Open
mrleblanc101 opened this issue Jan 25, 2024 · 17 comments
Open

Repeater styling #6166

mrleblanc101 opened this issue Jan 25, 2024 · 17 comments

Comments

@mrleblanc101
Copy link

  • Laravel Version: 10.41.0
  • Nova Version: 4.32.11
  • PHP Version: 8.1

Description:

Is it normal that the repeater trash icon is not uniform with the rest of nova ?

Screenshot 2024-01-25 at 12 36 31 AM Screenshot 2024-01-25 at 12 42 08 AM
@mrleblanc101
Copy link
Author

mrleblanc101 commented Jan 25, 2024

Also, my field is shown in the edit view and save just fine.

Repeater::make(__('Links'), 'links')
    ->repeatables([
        \App\Nova\Repeater\ProjectLink::make()->confirmRemoval(),
    ])->asJson(),
Screenshot 2024-01-25 at 12 44 59 AM

But is it normal that my field is not shown in the detail view ?

Screenshot 2024-01-25 at 12 45 07 AM

@mrleblanc101
Copy link
Author

The ->confirmRemoval() does not appear to do anything either 🤔

@Navi2016

This comment was marked as off-topic.

@mrleblanc101
Copy link
Author

@Navi2016 Yeah I opened a PR to the docs, but they don't seem to care: laravel/nova-docs#570.

This comment was marked as off-topic.

@stale stale bot added the stale label Mar 17, 2024
@mrleblanc101
Copy link
Author

Not stale

@sp4cecat

This comment was marked as off-topic.

@stale stale bot removed the stale label Mar 27, 2024
@sp4cecat
Copy link

Which BTW I would like to see also

@mrleblanc101

This comment was marked as off-topic.

@caongan2

This comment was marked as off-topic.

@sp4cecat

This comment was marked as off-topic.

@christian-heiko
Copy link

Any Update/Roadmap on this?

@christian-heiko

This comment was marked as off-topic.

@crynobone crynobone added this to the 5.x milestone May 15, 2024
@bergstar

This comment was marked as off-topic.

@crynobone crynobone added the next label Jul 23, 2024
@shriramms99
Copy link

I would also like to see the JSON column details on the resource page as mentioned in #6166 (comment) by @mrleblanc101

@msucevan
Copy link

msucevan commented Aug 2, 2024

+1

@PaLemmen
Copy link

Not totally sure if I just stack below this issue, but the name of the issue is 'Repeater styling' so here I go.
I am trying to use the Repeater field as a block builder, but the select when having multiple repeaterables isn't that UX friendly.

Screenshot 2024-08-12 at 23 20 01

When having multiple types of repeatables the vue swaps to Dropdownmenu instead of InvertedButton.
Only the DropdownMenu inside of the RepeaterField.vue is missing a width defination or the fallback width value of the DropdownMenu should be 'auto'.

In the current situation when nothing is defined it will be fixed to 120px.
Which isn't a lot with also the icon before, and leaving therefor only space for about 7 character as label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants