Display memory usage #297
Merged
Display memory usage #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Laravel documentation does not provide how to check for memory leaks, many developers will opt in to use the Laravel debug bar but i found out that the debug bar it has a memory leak, so displaying the memory usage as well as the duration will help to easy spot, memory leaks without external tools.
|
This PR broke the test suite. |
|
@driesvints On it. |
|
Sorry guys my bad, for the assertEquals on the test_request() function: 1 extra space needs to be removed and also the display of the 500 request. the mb needs to be updated from '23.46' to '28.43'. I will be more careful while opening pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Laravel documentation does not provide how to check for memory leaks, many developers will opt in to use the Laravel debug bar, but i found out that the debug bar it has a memory leak itself, so displaying the memory usage besides the duration of each request will help to easy spot memory leaks without external tools.