Addresses #332: pass config-file path for roadrunner #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namoshek
reviewed
Jun 28, 2021
| touch(base_path('.rr.yaml')); | ||
| return base_path('.rr.yaml'); | ||
| } | ||
| return $this->option('config-path'); |
There was a problem hiding this comment.
Would it make sense here to allow different styles of config paths to be passed?
php artisan octane:start --config-path=rr.prod.yml
php artisan octane:start --config-path=config/rr.prod.yml
php artisan octane:start --config-path=./config/rr.prod.yml
php artisan octane:start --config-path=../config/rr.prod.yml
php artisan octane:start --config-path=/etc/roadrunner/rr.prod.yml
There was a problem hiding this comment.
Thank you, I have added absolute path 58f1dcf
kevincobain2000
commented
Jun 29, 2021
kevincobain2000
commented
Jun 29, 2021
|
The flag was renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted with intentions for a first review and consideration.
Reasons for this pull request:
.rr.yamlbased on different environmentsdeployer. As this is symbolic link deployment, thebase_path()picks up the path from thereleases/<id>reference instead of the symb link. It'd be nice if we could provide a path via cli.The first option is more encouraging, as this config file is most likely to be on the server in a different location.