Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix the bug of Swoole\Table using array access #359

Merged
merged 2 commits into from
Aug 6, 2021
Merged

[1.x] Fix the bug of Swoole\Table using array access #359

merged 2 commits into from
Aug 6, 2021

Conversation

sy-records
Copy link
Contributor

@sy-records sy-records commented Aug 6, 2021

Swoole has removed Swoole\Table\Row since v4.7.0 (swoole/swoole-src#4297), so you can't read or write Table as an array anymore.

This PR is compatible with lower versions of Swoole.

Of course, Swoole doesn't recommend using arrays for reading and writing, but rather using API.

@taylorotwell taylorotwell merged commit 908c117 into laravel:1.x Aug 6, 2021
@sy-records sy-records deleted the swoole_table branch August 6, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants