Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ServerProcessInspector interface #679

Merged
merged 3 commits into from
Apr 18, 2023
Merged

add ServerProcessInspector interface #679

merged 3 commits into from
Apr 18, 2023

Conversation

yiming0
Copy link
Contributor

@yiming0 yiming0 commented Apr 18, 2023

No description provided.

@driesvints
Copy link
Member

Please provide a thorough explanation why you need this.

@yiming0
Copy link
Contributor Author

yiming0 commented Apr 18, 2023 •
edited

Please provide a thorough explanation why you need this.

While developing a solution to start Laravel Octane using other PHP asynchronous frameworks, I encountered a warning about the parameter type hinting in Laravel\Octane\Commands\Concerns\InteractsWithServers::runServer.

I think Laravel Octane will not only serve swoole and roadrunner in the future, so I added the \Laravel\Octane\Contracts\ServerProcessInspector interface.

@taylorotwell taylorotwell merged commit 6758daa into laravel:1.x Apr 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yiming0 @driesvints @taylorotwell